Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3261 Sort constraint status audit results #3277

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

prachirp
Copy link
Contributor

What this PR does / why we need it: This change sorts auditResults to reduce churn in which violations are reported in constraint status.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3261

Special notes for your reviewer: Refer to the linked issue for discussion

Signed-off-by: Prachi Pendse <prachirp@google.com>
@prachirp prachirp requested a review from a team as a code owner February 20, 2024 20:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (075b092) 54.40% compared to head (b513dd5) 54.34%.

Files Patch % Lines
pkg/audit/manager.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3277      +/-   ##
==========================================
- Coverage   54.40%   54.34%   -0.06%     
==========================================
  Files         134      134              
  Lines       12332    12356      +24     
==========================================
+ Hits         6709     6715       +6     
- Misses       5127     5146      +19     
+ Partials      496      495       -1     
Flag Coverage Δ
unittests 54.34% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/audit/manager.go Outdated Show resolved Hide resolved
Signed-off-by: Prachi Pendse <prachirp@google.com>
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit fed8e15 into open-policy-agent:master Feb 22, 2024
16 checks passed
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
…-policy-agent#3277)

Signed-off-by: Prachi Pendse <prachirp@google.com>
Co-authored-by: Max Smythe <smythe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint status content is non-deterministic
4 participants