-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3261 Sort constraint status audit results #3277
Conversation
Signed-off-by: Prachi Pendse <prachirp@google.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3277 +/- ##
==========================================
- Coverage 54.40% 54.34% -0.06%
==========================================
Files 134 134
Lines 12332 12356 +24
==========================================
+ Hits 6709 6715 +6
- Misses 5127 5146 +19
+ Partials 496 495 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Prachi Pendse <prachirp@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-policy-agent#3277) Signed-off-by: Prachi Pendse <prachirp@google.com> Co-authored-by: Max Smythe <smythe@google.com>
What this PR does / why we need it: This change sorts auditResults to reduce churn in which violations are reported in constraint status.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3261
Special notes for your reviewer: Refer to the linked issue for discussion