Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade controller-runtime to 0.17.2, remove fork #3278

Conversation

maxsmythe
Copy link
Contributor

What this PR does / why we need it:

Removes the controller-runtime fork!

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@maxsmythe maxsmythe requested a review from a team as a code owner February 21, 2024 21:37
@maxsmythe maxsmythe force-pushed the upgrade-controller-runtime-remove-fork branch from 88fdeed to 217591a Compare February 21, 2024 21:46
@maxsmythe maxsmythe changed the title Upgrade controller-runtime to 0.17.2, remove fork chore: Upgrade controller-runtime to 0.17.2, remove fork Feb 21, 2024
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe force-pushed the upgrade-controller-runtime-remove-fork branch from 217591a to e02cb4c Compare February 21, 2024 21:57
@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (1466180) 54.43% compared to head (e02cb4c) 54.45%.

Files Patch % Lines
pkg/webhook/common.go 0.00% 14 Missing ⚠️
pkg/watch/manager.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
+ Coverage   54.43%   54.45%   +0.02%     
==========================================
  Files         134      134              
  Lines       12318    12332      +14     
==========================================
+ Hits         6705     6716      +11     
- Misses       5116     5121       +5     
+ Partials      497      495       -2     
Flag Coverage Δ
unittests 54.45% <11.76%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bye bye fork :)

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@sozercan sozercan mentioned this pull request Feb 22, 2024
@maxsmythe maxsmythe merged commit 8d71af0 into open-policy-agent:master Feb 22, 2024
16 of 17 checks passed
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants