Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing metrics views #3307

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it: Order of registering views in otel metrics was no in orientation and is causing views to used default configurations instead of custom.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3303

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@JaydipGabani JaydipGabani requested a review from a team as a code owner March 14, 2024 06:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (3350319) to head (71bd2a6).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3307      +/-   ##
==========================================
- Coverage   54.49%   54.33%   -0.16%     
==========================================
  Files         134      134              
  Lines       12329    10258    -2071     
==========================================
- Hits         6719     5574    -1145     
+ Misses       5116     4180     -936     
- Partials      494      504      +10     
Flag Coverage Δ
unittests 54.33% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani merged commit 982a31d into open-policy-agent:master Mar 15, 2024
16 checks passed
@JaydipGabani JaydipGabani deleted the otel branch March 15, 2024 12:24
JaydipGabani added a commit to JaydipGabani/gatekeeper that referenced this pull request Mar 15, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
(cherry picked from commit 982a31d)
JaydipGabani added a commit to JaydipGabani/gatekeeper that referenced this pull request Mar 15, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
(cherry picked from commit 982a31d)
JaydipGabani added a commit to JaydipGabani/gatekeeper that referenced this pull request Mar 15, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
(cherry picked from commit 982a31d)
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course aggregation of request duration metrics
3 participants