-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing metrics views #3307
Conversation
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3307 +/- ##
==========================================
- Coverage 54.49% 54.33% -0.16%
==========================================
Files 134 134
Lines 12329 10258 -2071
==========================================
- Hits 6719 5574 -1145
+ Misses 5116 4180 -936
- Partials 494 504 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 982a31d)
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 982a31d)
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 982a31d)
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
What this PR does / why we need it: Order of registering views in otel metrics was no in orientation and is causing views to used default configurations instead of custom.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3303
Special notes for your reviewer: