-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable toggling of deferring to VAP #3335
feat: Enable toggling of deferring to VAP #3335
Conversation
Signed-off-by: Max Smythe <smythe@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3335 +/- ##
==========================================
- Coverage 54.49% 46.76% -7.74%
==========================================
Files 134 218 +84
Lines 12329 14784 +2455
==========================================
+ Hits 6719 6913 +194
- Misses 5116 7069 +1953
- Partials 494 802 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d396df1
to
9a04f45
Compare
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Max Smythe <max.smythe@gmail.com>
9a04f45
to
bb3a7a8
Compare
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: Max Smythe <max.smythe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Max Smythe <max.smythe@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
What this PR does / why we need it:
Implementation of feature set for VAP generation
Fixes #3331
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: