Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): matchConditions added in Validating & MutatingWebhookConfiguration #3343

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

leewoobin789
Copy link
Contributor

…iguration

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3038

Fixes also previous PR that has become stale: #3100

Special notes for your reviewer:

…iguration

Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
@leewoobin789 leewoobin789 requested a review from a team as a code owner April 1, 2024 12:56
@leewoobin789
Copy link
Contributor Author

@JaydipGabani Sorry for being late. this fixes also the formatting error you had in CI (of PR #3100)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.76%. Comparing base (3350319) to head (cdb4c77).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
- Coverage   54.49%   46.76%   -7.74%     
==========================================
  Files         134      218      +84     
  Lines       12329    14784    +2455     
==========================================
+ Hits         6719     6913     +194     
- Misses       5116     7069    +1953     
- Partials      494      802     +308     
Flag Coverage Δ
unittests 46.76% <ø> (-7.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!

@ritazh ritazh merged commit a2e5e29 into open-policy-agent:master Apr 2, 2024
19 of 20 checks passed
@sathieu
Copy link
Contributor

sathieu commented May 14, 2024

This PR made our ArgoCD app OutOfSync, proposed fix: #3383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhooks intercepting exclude specific resources
6 participants