-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): matchConditions added in Validating & MutatingWebhookConfiguration #3343
Conversation
…iguration Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
@JaydipGabani Sorry for being late. this fixes also the formatting error you had in CI (of PR #3100) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
- Coverage 54.49% 46.76% -7.74%
==========================================
Files 134 218 +84
Lines 12329 14784 +2455
==========================================
+ Hits 6719 6913 +194
- Misses 5116 7069 +1953
- Partials 494 802 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR!
This PR made our ArgoCD app OutOfSync, proposed fix: #3383 |
…iguration
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3038
Fixes also previous PR that has become stale: #3100
Special notes for your reviewer: