Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing deprecating function in dapr fake test client #3451

Merged

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:
updating dapr fake client to use non deprecated function for initializing clients. Should fix ci-error on #3446

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@JaydipGabani JaydipGabani requested a review from a team as a code owner July 17, 2024 21:21
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@JaydipGabani JaydipGabani changed the title chore: fixing deprecating function chore: fixing deprecating function in dapr fake test client Jul 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.78%. Comparing base (3350319) to head (d619f17).
Report is 96 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (d619f17). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (d619f17)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3451      +/-   ##
==========================================
- Coverage   54.49%   46.78%   -7.72%     
==========================================
  Files         134      218      +84     
  Lines       12329    14786    +2457     
==========================================
+ Hits         6719     6917     +198     
- Misses       5116     7069    +1953     
- Partials      494      800     +306     
Flag Coverage Δ
unittests 46.78% <100.00%> (-7.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for the fix!

@JaydipGabani JaydipGabani merged commit 159cf30 into open-policy-agent:master Jul 18, 2024
19 checks passed
@JaydipGabani JaydipGabani deleted the dapr-fake-client branch July 18, 2024 14:13
Ankurk99 pushed a commit to Ankurk99/gatekeeper that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants