Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OPA version to decision logs. #1089

Closed
pwmorreale opened this issue Nov 26, 2018 · 2 comments
Closed

Add OPA version to decision logs. #1089

pwmorreale opened this issue Nov 26, 2018 · 2 comments
Labels
good first issue

Comments

@pwmorreale
Copy link

Enhancement request:

Add the OPA semver version string to the datum in a decision log.

From a record-keeping standpoint, its very useful to tie both the configuration (revision id) and the particular version of OPA used together.

Currently the data in OPA decision logs does not include the OPA semver version.
@tsandall
Copy link
Member

This seems like a useful feature. The version information is compiled into the OPA binary (see the version package). We can extend OPA to include this field in the decision log events.

@BenderScript
Copy link
Contributor

I will take a stab

This was referenced Jan 9, 2019
Merged
Closed
tsandall pushed a commit that referenced this issue Jan 10, 2019
@BenderScript @tsandall
Add OPA version to decision logs
1773cf6 
Fixes #1089

=== RUN   TestPluginStartSameInput
--- PASS: TestPluginStartSameInput (0.02s)
=== RUN   TestPluginStartChangingInputValues
--- PASS: TestPluginStartChangingInputValues (0.01s)
=== RUN   TestPluginStartChangingInputKeysAndValues
--- PASS: TestPluginStartChangingInputKeysAndValues (0.01s)
=== RUN   TestPluginRequeue
--- PASS: TestPluginRequeue (0.00s)
=== RUN   TestPluginReconfigure
time="2019-01-09T09:34:03-08:00" level=info msg="Starting decision log uploader." plugin=decision_logs
time="2019-01-09T09:34:03-08:00" level=info msg="Log upload skipped." plugin=decision_logs
time="2019-01-09T09:34:03-08:00" level=info msg="Stopping decision log uploader." plugin=decision_logs
time="2019-01-09T09:34:03-08:00" level=info msg="Decision log uploader configuration changed." plugin=decision_logs
time="2019-01-09T09:34:03-08:00" level=info msg="Log upload skipped." plugin=decision_logs
--- PASS: TestPluginReconfigure (0.00s)
PASS

Signed-off-by: repenno <rapenno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsandall @pwmorreale @BenderScript