Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting in OPA server #1367

Closed
ashutosh-narkar opened this issue Apr 22, 2019 · 1 comment · Fixed by #1658
Closed

Improve error reporting in OPA server #1367

ashutosh-narkar opened this issue Apr 22, 2019 · 1 comment · Fixed by #1658
Assignees
@tsandall

Comments

@ashutosh-narkar
Copy link
Member

Expected Behavior

OPA server should differentiate between errors generated by OPA proper and errors reported by the decision logger.

Actual Behavior

OPA server logs errors returned by the decision logger using one of OPA's error codes eg. internal_error .

Steps to Reproduce the Problem

  1. Start OPA and a decision log plugin
  2. Return an error from the decision logger
  3. OPA logs the error as one of OPA's error codes
@tsandall
Copy link
Member

tsandall commented Jun 20, 2019 •
edited
Loading

We can prefix the error message to indicate it came from a decision logger.

tsandall added a commit to tsandall/opa that referenced this issue Aug 22, 2019
@tsandall
server: Wrap decision log error messages
cb2ce75 
Previously the server didn't wrap the error messages which made it
hard to determine the source of internal errors coming back from OPA
when deployed with a custom decision logger.

Fixes open-policy-agent#1367

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@tsandall tsandall self-assigned this Aug 22, 2019
@tsandall tsandall mentioned this issue Aug 22, 2019
Merged
tsandall added a commit that referenced this issue Aug 22, 2019
@tsandall
server: Wrap decision log error messages
df281fd 
Previously the server didn't wrap the error messages which made it
hard to determine the source of internal errors coming back from OPA
when deployed with a custom decision logger.

Fixes #1367

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsandall tsandall

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: Wrap decision log error messages tsandall/opa
2 participants
@tsandall @ashutosh-narkar