Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server leaks write transaction if parse fails on update #1478

Closed
tsandall opened this issue Jun 11, 2019 · 0 comments · Fixed by #1481
Closed

Server leaks write transaction if parse fails on update #1478

tsandall opened this issue Jun 11, 2019 · 0 comments · Fixed by #1481
Assignees
@tsandall

Comments

@tsandall
Copy link
Member

tsandall commented Jun 11, 2019 •
edited
Loading

The server is not aborting the write transaction when PUT /v1/policies fails due to an malformed or empty policy. The server is then unable to process further policy updates because of the open write transaction.

This is causing open-policy-agent/kube-mgmt#41.

EDIT: This will get fixed in the next day and we'll cut a v0.11.1 release containing the fix.
@tsandall tsandall self-assigned this Jun 11, 2019
@tsandall tsandall mentioned this issue Jun 11, 2019
Merged
tsandall added a commit to tsandall/opa that referenced this issue Jun 11, 2019
@tsandall
server: Abort write transaction when parsing fails
99d9df1 
The server was leaking the write transaction when parsing failed which
caused subsequent updates to block. In future we should refactor the
handler implementations to avoid having to manually abort on each
error path.

Fixes open-policy-agent#1478

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall added a commit that referenced this issue Jun 11, 2019
@tsandall
server: Abort write transaction when parsing fails
844d410 
The server was leaking the write transaction when parsing failed which
caused subsequent updates to block. In future we should refactor the
handler implementations to avoid having to manually abort on each
error path.

Fixes #1478

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@strajansebastian strajansebastian mentioned this issue Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsandall tsandall

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: Abort write transaction when parsing fails tsandall/opa
1 participant
@tsandall