Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle updates should not block policy queries #1515

Closed
tsandall opened this issue Jun 23, 2019 · 0 comments · Fixed by #1516
Closed

Bundle updates should not block policy queries #1515

tsandall opened this issue Jun 23, 2019 · 0 comments · Fixed by #1516
Assignees
@tsandall

Comments

@tsandall
Copy link
Member

Expected Behavior

Bundle updates should not block policy queries. Parsing and compiling of the bundle contents should happen concurrently with policy queries.

Actual Behavior

The manager parses and compiles modules during its storage trigger callback. Since triggers are executed while writes are committed, the read lock is held and so policy queries block.
@tsandall tsandall self-assigned this Jun 23, 2019
tsandall added a commit to tsandall/opa that referenced this issue Jun 23, 2019
@tsandall
bundle: Cache compiler on storage context
b0cf389 
These changes update the manager and bundle plugin to avoid parsing
and compiling modules during the manager's trigger callback. Since
policy queries are blocked while triggers execute, it's adavantageous
to cache the compiler that is obtained during bundle activation and
reduce the work done in the trigger callback.

Also, as part of these changes, the bundle plugin incorporates
remaining modules when it recompiles. This ensures that remaining
modules are correct.

Fixes open-policy-agent#1515

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@tsandall tsandall mentioned this issue Jun 23, 2019
Merged
patrick-east pushed a commit that referenced this issue Jun 24, 2019
@tsandall @patrick-east
bundle: Cache compiler on storage context
e4ae6a7 
These changes update the manager and bundle plugin to avoid parsing
and compiling modules during the manager's trigger callback. Since
policy queries are blocked while triggers execute, it's adavantageous
to cache the compiler that is obtained during bundle activation and
reduce the work done in the trigger callback.

Also, as part of these changes, the bundle plugin incorporates
remaining modules when it recompiles. This ensures that remaining
modules are correct.

Fixes #1515

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall added a commit to tsandall/opa that referenced this issue Jul 27, 2019
@tsandall
bundle: Cache compiler on storage context
06a255e 
These changes update the manager and bundle plugin to avoid parsing
and compiling modules during the manager's trigger callback. Since
policy queries are blocked while triggers execute, it's adavantageous
to cache the compiler that is obtained during bundle activation and
reduce the work done in the trigger callback.

Also, as part of these changes, the bundle plugin incorporates
remaining modules when it recompiles. This ensures that remaining
modules are correct.

Fixes open-policy-agent#1515

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall added a commit that referenced this issue Jul 27, 2019
@tsandall
bundle: Cache compiler on storage context
6956460 
These changes update the manager and bundle plugin to avoid parsing
and compiling modules during the manager's trigger callback. Since
policy queries are blocked while triggers execute, it's adavantageous
to cache the compiler that is obtained during bundle activation and
reduce the work done in the trigger callback.

Also, as part of these changes, the bundle plugin incorporates
remaining modules when it recompiles. This ensures that remaining
modules are correct.

Fixes #1515

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsandall tsandall

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix performance impact of bundle activation on policy queries tsandall/opa
1 participant
@tsandall