Change underlying number representation to handle large integers #154
Comments
tsandall
added a commit
to tsandall/opa
that referenced
this issue
Dec 5, 2016
These changes modify OPA to use json.Number to represent number values in storage and the AST. Comparisons and numeric operations are handled by the math/big package. Using json.Number avoids loss of precision when loading integers greater than 2**53 and use of math/big avoids need for type conversions in the built-in implementations. In the long run, the math/big usage may be replaced with specific paths for smaller numbers. Fixes open-policy-agent#154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OPA currently uses float64 as the underlying number representation in storage and the AST. Float64 was used initially because this is the default return type for numbers in
encoding/json. Unfortunately this leads to loss of precision when dealing with large int64 values.One solution would be to switch to json.Number (string) as the underlying representation.
The text was updated successfully, but these errors were encountered: