Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Terraform guide to show nested child_modules #1772

Closed
patrick-east opened this issue Sep 18, 2019 · 3 comments · Fixed by #2411 or #2425
Closed

docs: Update Terraform guide to show nested child_modules #1772

patrick-east opened this issue Sep 18, 2019 · 3 comments · Fixed by #2411 or #2425
Labels
docs int-terraform Issues related to Terraform plan and module policies or integrations.

Comments

@patrick-east
Copy link
Contributor

The current Terraform guide works as expected, but the example only shows using a root_module and no child_modules nested further down.

This is likely to be a common thing that people run into as it is considered good practice to make smaller modules and piece together larger plans with them.

We should update the docs to show an example and give some hints around how to collect all of the resources.

For reference:

@patrick-east patrick-east added the int-terraform Issues related to Terraform plan and module policies or integrations. label Jan 14, 2020
@princespaghetti
Copy link
Contributor

@patrick-east I'll take a pass at this. Are you thinking an additional example in addition to the blast radius one, or modifying the current one to also have a module included?

@patrick-east
Copy link
Contributor Author

I think another example, maybe doesn't need to be as complex. Just showing how to deal with collecting resources from the child modules.

@princespaghetti
Copy link
Contributor

Sounds good! I'll start working on that

patrick-east pushed a commit that referenced this issue May 21, 2020
Fixes: #1772
Signed-off-by: Anthony Barbieri <anthonyabarbieri@gmail.com>
patrick-east pushed a commit that referenced this issue May 22, 2020
Fixes: #1772
Signed-off-by: Anthony Barbieri <anthonyabarbieri@gmail.com>
patrick-east pushed a commit to patrick-east/opa that referenced this issue May 22, 2020
Fixes: open-policy-agent#1772
Signed-off-by: Anthony Barbieri <anthonyabarbieri@gmail.com>
(cherry picked from commit 1775a7d)
patrick-east pushed a commit that referenced this issue May 22, 2020
Fixes: #1772
Signed-off-by: Anthony Barbieri <anthonyabarbieri@gmail.com>
(cherry picked from commit 1775a7d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs int-terraform Issues related to Terraform plan and module policies or integrations.
Projects
Archived in project
2 participants