Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tls_ca_cert_file without client certificates #1976

Closed
tsandall opened this issue Dec 27, 2019 · 0 comments · Fixed by #2066
Closed

Support tls_ca_cert_file without client certificates #1976

tsandall opened this issue Dec 27, 2019 · 0 comments · Fixed by #2066
Assignees
@patrick-east

Comments

@tsandall
Copy link
Member

The http.send function should accept a CA certificate file w/o a client certificate. Currently the function ignores the CA certificate file unless a client certificate is also specified.
patrick-east added a commit to patrick-east/opa that referenced this issue Feb 6, 2020
@patrick-east
topdown: http.send use provided CA without client certs
df39700 
Previously it would ignore the provided CA parameters unless client
cert info was provided. This change now allows for providing CA info
without any client auth details.

Fixes: open-policy-agent#1976
Signed-off-by: Patrick East <east.patrick@gmail.com>
@patrick-east patrick-east mentioned this issue Feb 6, 2020
Merged
@patrick-east patrick-east self-assigned this Feb 6, 2020
tsandall pushed a commit that referenced this issue Feb 17, 2020
@patrick-east @tsandall
topdown: http.send use provided CA without client certs
7a9046f 
Previously it would ignore the provided CA parameters unless client
cert info was provided. This change now allows for providing CA info
without any client auth details.

Fixes: #1976
Signed-off-by: Patrick East <east.patrick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick-east patrick-east

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

topdown: http.send use provided CA without client certs patrick-east/opa
2 participants
@tsandall @patrick-east