Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve query eval metrics to report http.send latency #2034

Closed
tsandall opened this issue Jan 24, 2020 · 0 comments · Fixed by #2629
Closed

Improve query eval metrics to report http.send latency #2034

tsandall opened this issue Jan 24, 2020 · 0 comments · Fixed by #2629
Assignees
@tsandall

Comments

@tsandall
Copy link
Member

Policies that invoke http.send are often bottlenecked on I/O. It would be useful to report the amount of time spent on http.send or other built-in functions that perform similar operations. There are a few options for solving this:

  1. Annotate built-in functions to indicate they should be reported specially
  2. Allow built-in functions to inject metrics into the evaluation context

Separately there's a decision about whether this should be on by default (or if the caller should have to opt-in).
@tsandall tsandall removed the design label Aug 13, 2020
@tsandall tsandall self-assigned this Aug 13, 2020
@tsandall tsandall mentioned this issue Aug 13, 2020
Merged
tsandall added a commit to tsandall/opa that referenced this issue Aug 13, 2020
@tsandall
topdown: Pass metrics to built-ins and record http.send latency
1c90afa 
Previously the built-in functions had no way to record metrics for
performance monitoring or other purposes. With this change, built-in
functions can manipulate the evaluation metrics. Initially, only the
http.send function has been updated to report latency.

Fixes open-policy-agent#2034

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall added a commit that referenced this issue Aug 14, 2020
@tsandall
topdown: Pass metrics to built-ins and record http.send latency
6507fa4 
Previously the built-in functions had no way to record metrics for
performance monitoring or other purposes. With this change, built-in
functions can manipulate the evaluation metrics. Initially, only the
http.send function has been updated to report latency.

Fixes #2034

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsandall tsandall

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

topdown: Pass metrics to built-ins and record http.send latency tsandall/opa
1 participant
@tsandall