-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additive updates to the services configuration when discovery is enabled #2058
Comments
Apart from migrations there are two other use cases where this can be useful:
|
Earlier with discovery enabled updates to the 'services' configuration was not allowed to protect against accidental changes to the discovery service itself. Since adding new services could be useful, this change allows modifications to the 'services' configuration. The only exception is that the service used to download the discovery bundle cannot be modified. Fixes open-policy-agent#2058 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Earlier with discovery enabled updates to the 'services' configuration was not allowed to protect against accidental changes to the discovery service itself. Since adding new services could be useful, this change allows modifications to the 'services' configuration. The only exception is that the service used to download the discovery bundle cannot be modified. Fixes #2058 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Earlier with discovery enabled, there was no protection against accidental changes to the discovery service. This change prevents the discovery service from being modified by checking it's config in the service bundle. Fixes open-policy-agent#2058 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Earlier with discovery enabled, there was no protection against accidental changes to the discovery service. This change prevents the discovery service from being modified by checking it's config in the service bundle. Fixes #2058 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Discovery is not currently able to update the
services
configuration in OPA. This was done to protect users from accidentally rendering the OPA inoperable (e.g., unable to reach the discovery service to pull down new bundles.) In some cases it would be useful to be able to add new services (e.g., when migrating from one service implementation to another.)To enable this use case we could relax the validation done by the discovery plugin to permit additive changes to the
services
configuration.The text was updated successfully, but these errors were encountered: