-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules can parse with wrapping curly braces #2199
Labels
Comments
tsandall
added a commit
to tsandall/opa
that referenced
this issue
Mar 25, 2020
This commit replaces the existing PEG generated parser with a parser implemented by hand. The new parser is more efficient (avoiding old problems with pathological input cases like {{{{{{{{{}}}}}}}} and deeply-nested composites in general) and offers better opportunities for improved error reporting (which has been improved already but there is still room to grow.) During the test process of implementing the new parser, we identified a few issues that were present in the old parser. Those issues are fixed by this commit. Fixes open-policy-agent#1251 Fixes open-policy-agent#501 Fixes open-policy-agent#2198 Fixes open-policy-agent#2199 Fixes open-policy-agent#2200 Fixes open-policy-agent#2201 Fixes open-policy-agent#2202 Fixes open-policy-agent#2203 Co-authored-by: Torin Sandall <torinsandall@gmail.com> Co-authored-by: Patrick East <east.patrick@gmail.com> Signed-off-by: Torin Sandall <torinsandall@gmail.com> Signed-off-by: Patrick East <east.patrick@gmail.com>
tsandall
added a commit
that referenced
this issue
Mar 26, 2020
This commit replaces the existing PEG generated parser with a parser implemented by hand. The new parser is more efficient (avoiding old problems with pathological input cases like {{{{{{{{{}}}}}}}} and deeply-nested composites in general) and offers better opportunities for improved error reporting (which has been improved already but there is still room to grow.) During the test process of implementing the new parser, we identified a few issues that were present in the old parser. Those issues are fixed by this commit. Fixes #1251 Fixes #501 Fixes #2198 Fixes #2199 Fixes #2200 Fixes #2201 Fixes #2202 Fixes #2203 Co-authored-by: Torin Sandall <torinsandall@gmail.com> Co-authored-by: Patrick East <east.patrick@gmail.com> Signed-off-by: Torin Sandall <torinsandall@gmail.com> Signed-off-by: Patrick East <east.patrick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
A rule defined like:
Should not be valid according to the grammar we document
Actual Behavior
It parses fine, as long as there is only a single set of braces.. ex:
Additional Info
We should probably raise an error for this case. IMO it is somewhat confusing, and probably not what the author intended as the curly braces mean nothing to the language, they're essentially ignored.
The text was updated successfully, but these errors were encountered: