Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for service bearer token refresh #2241

Closed
tsandall opened this issue Mar 30, 2020 · 0 comments · Fixed by #2287
Closed

Improve support for service bearer token refresh #2241

tsandall opened this issue Mar 30, 2020 · 0 comments · Fixed by #2287
Assignees
@ashutosh-narkar

Comments

@tsandall
Copy link
Member

tsandall commented Mar 30, 2020 •
edited
Loading

Service clients using bearer tokens should be able to refresh those tokens without requiring a process restart. We support this today for mutual TLS so we should be able to do something similar for bearer token usage.

The easiest solution (IMO) would be to add a new services[_].credentials.bearer.path configuration field (name TBD) that specifies the path of a file containing the bearer token to read. OPA would re-read the file like it does with TLS certs/keys.

@patrick-east what do you think?
@ashutosh-narkar ashutosh-narkar self-assigned this Apr 10, 2020
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Apr 10, 2020
@ashutosh-narkar
plugins: Add support to specify bearer token path
7132f30 
This change updates the bearer token config to allow clients to specify
a path to the token. With this refreshing tokens becomes easier as OPA
will now reload the token from file.

Fixes open-policy-agent#2241

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar ashutosh-narkar mentioned this issue Apr 10, 2020
Merged
ashutosh-narkar added a commit that referenced this issue Apr 11, 2020
@ashutosh-narkar
plugins: Add support to specify bearer token path
a5be4f4 
This change updates the bearer token config to allow clients to specify
a path to the token. With this refreshing tokens becomes easier as OPA
will now reload the token from file.

Fixes #2241

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashutosh-narkar ashutosh-narkar

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugins: Add support to specify bearer token path ashutosh-narkar/opa
2 participants
@tsandall @ashutosh-narkar