Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration doc has two compile errors in example Go code #2367

Closed
tsandall opened this issue Apr 30, 2020 · 4 comments
Closed

Integration doc has two compile errors in example Go code #2367

tsandall opened this issue Apr 30, 2020 · 4 comments
Labels
docs good first issue help wanted

Comments

@tsandall
Copy link
Member

The Go integration section in https://github.com/open-policy-agent/opa/blob/master/docs/content/integration.md contains two errors in the example code:

  1. module is not defined anywhere. module should be defined as a string variable that contains the example policy from earlier in the page.

  2. context.Context should just be `ctx.
@sresthas
Copy link
Contributor

Can I take this up?

@patrick-east
Copy link
Contributor

@sresthas I've assigned the issue to you, let us know if you need any guidance.

@agarwalrounak
Copy link
Contributor

Can I take this issue up? I have figured out the corrections needed to be made to resolve this issue.

@patrick-east
Copy link
Contributor

@sresthas were you still working on this one?

gaga5lala added a commit to gaga5lala/opa that referenced this issue Jun 23, 2020
@gaga5lala
docs/content: fix go integration example
1cff7cb 
1. module should be policy string above
2. pass context instance for .Eval

also add decision output in the example

Fixes open-policy-agent#2367

Signed-off-by: Gaga Pan <gaga5lala1013@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs good first issue help wanted
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsandall @patrick-east @sresthas @agarwalrounak