Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with rewriting single term expressions when len(query) > 1 #299

Closed
tsandall opened this issue Mar 22, 2017 · 0 comments
Closed

Issue with rewriting single term expressions when len(query) > 1 #299

tsandall opened this issue Mar 22, 2017 · 0 comments
Labels

Comments

@tsandall
Copy link
Member

tsandall commented Mar 22, 2017

Currently the high level API rewrites non-negated single term expressions to capture the term value regardless of whether the len(query) is 1. This is incorrect in the case where one of the expressions is a single term that evaluates to false.

In addition to capturing the term value, the rewritten query must still check if the value is false.

@tsandall tsandall added the bug label Mar 22, 2017
@tsandall tsandall changed the title High level API should not rewrite single term expressions if len(query) > 1 Issue with rewriting single term expressions when len(query) > 1 Mar 22, 2017
tsandall added a commit to tsandall/opa that referenced this issue Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant