Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL incorrectly creating rules for some input refs #433

Closed
tsandall opened this issue Aug 29, 2017 · 0 comments
Closed

REPL incorrectly creating rules for some input refs #433

tsandall opened this issue Aug 29, 2017 · 0 comments
Labels

Comments

@tsandall
Copy link
Member

The partial doc shorthand improvement (#425) caused the REPL to interpret some refs to input docs as rule definitions when they should not be. For example:

OPA 0.5.6-dev (commit 4a4af6b, built at 2017-08-29T17:50:50Z)

Run 'help' to see a list of commands.

> input.p
> input
[
  "p"
]
> unset input
> input.p = 1
> show
package repl

input["p"] = 1

version = {
	"Version": "0.5.6-dev",
	"BuildCommit": "4a4af6b",
	"BuildTimestamp": "2017-08-29T17:50:50Z",
	"BuildHostname": "testing-gce-a89e468d-2e98-487a-8a82-deea63e462ab",
}
tsandall added a commit to tsandall/opa that referenced this issue Aug 29, 2017
These changes refactor the parser extensions that convert bodies into
rules if they can interpreted as such. The cases that can be converted
are clearer now and the test coverage is improved.

Fixes open-policy-agent#433
tsandall added a commit that referenced this issue Aug 29, 2017
These changes refactor the parser extensions that convert bodies into
rules if they can interpreted as such. The cases that can be converted
are clearer now and the test coverage is improved.

Fixes #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant