-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove replace directives from go.mod #7024
Comments
Hi there! And thanks for filing this issue. And I agree, that would be nice. The trade-off we're looking at seems to be between supporting |
Related: StyraInc/regal#490 |
Indeed. In that case it was a no-brainer to just get rid of the replace, while it solves (or at least solved!) an actual issue here. But looking at the git history, that replace is from 2022, and I don't think anyone looked at it since then. So it could very well be that the issue has been fixed upstream. I don't have much time to look into it this week, and no windows machine to test with 😅 But if someone has the bandwidth to investigate, that would be much appreciated! |
I'll have a quick look. This looks promising -- two months ago 😎 -- golang/glog@9730314 |
Just recently, glog introduced a fix for the potentially very expensive network call on windows that had been troubling us before: golang/glog@9730314 It's become the v1.2.2 release. The release is now in vendor, and the replacement has been removed. Fixes open-policy-agent#7024. Signed-off-by: Stephan Renatus <stephan@styra.com>
Just recently, glog introduced a fix for the potentially very expensive network call on windows that had been troubling us before: golang/glog@9730314 It's become the v1.2.2 release. The release is now in vendor, and the replacement has been removed. Fixes #7024. Signed-off-by: Stephan Renatus <stephan@styra.com>
What is the underlying problem you're trying to solve?
go run github.com/open-policy-agent/opa@v0.68.0 or go install github.com/open-policy-agent/opa@v0.68.0 will not work and results in to an error
The replace statement in question is go.mod#L120.
Describe the ideal solution
The ideal solution would be that you can go run the opa policy agent directly via
go run
or you can install it directly withgo install
instead of relying on package manager.Describe a "Good Enough" solution
Creating RPM packages and other packages for easier installation of opa executable is more work than fixing the replace statement.
Additional Context
The golang team is not willing to support
replace
statements withgo install
orgo run
: golang/go#44840The text was updated successfully, but these errors were encountered: