Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes deployment docs example to avoid confusion #874

Closed
tsandall opened this issue Aug 8, 2018 · 0 comments · Fixed by #1343
Closed

Update Kubernetes deployment docs example to avoid confusion #874

tsandall opened this issue Aug 8, 2018 · 0 comments · Fixed by #1343
Assignees
Labels

Comments

@tsandall
Copy link
Member

tsandall commented Aug 8, 2018

The Deployment docs for Kubernetes include an example query that provides a Pod object as input. This is confusing for new users because they expect to be able to write admission control policies that refer to resources rooted at input -- whereas Kubernetes admission control webhooks root the resource under input.request.object.

We should just replace the example in the Deployment docs with something generic and then refer to readers to the Admission Control tutorial if they are interested.

The doc in question: https://github.com/open-policy-agent/opa/blob/master/docs/book/deployments.md#kicking-the-tires

@tsandall tsandall added the docs label Aug 8, 2018
@tsandall tsandall self-assigned this Apr 12, 2019
tsandall added a commit to tsandall/opa that referenced this issue Apr 17, 2019
Fixes open-policy-agent#874

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall added a commit that referenced this issue Apr 17, 2019
Fixes #874

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant