Add array.slice built-in function #1287
Conversation
Fixes open-policy-agent#1243 Signed-off-by: Ravi Soni <soniravi829@gmail.com>
Signed-off-by: lucperkins <lucperkins@gmail.com>
Signed-off-by: Teemu Koponen <koponen@styra.com>
Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Signed-off-by: Torin Sandall <torinsandall@gmail.com>
There was a problem hiding this comment.
@Infi-Knight These changes look good. Please update the language-reference.md file with the new built-in. There should be an existing section for array built-ins. Just add to that section.
The tutorial for the admission controller was using an older release of the kube-mgmt sidecar. This just updates to the latest (as of now) tagged release. Tested following the full tutorial and all steps work as expected with the new version being used instead of 0.6. Signed-off-by: Patrick East <east.patrick@gmail.com>
array.slice will return a copy of the original array instead of returning errors when the slicing indices are invalid. Signed-off-by: Ravi Soni <soniravi829@gmail.com>
Signed-off-by: Ravi Soni <soniravi829@gmail.com>
|
@Infi-Knight thanks for my addressing my feedback. I appreciate the formatting changes you made in the language-reference.md file, but please undo them. The reason is that most people don't have automated formatting of Markdown enabled and we don't want to gate PRs on this. Thanks. Once those changes are undone (and the language-reference.md file has been updated to include a row for the |
I apologize for this issue. My editor configuration messed it up. Will revert it straight away. |
Signed-off-by: Ravi Soni <soniravi829@gmail.com>
Fixes open-policy-agent#1243 Signed-off-by: Ravi Soni <soniravi829@gmail.com>
array.slice will return a copy of the original array instead of returning errors when the slicing indices are invalid. Signed-off-by: Ravi Soni <soniravi829@gmail.com>
Signed-off-by: Ravi Soni <soniravi829@gmail.com>
Signed-off-by: Ravi Soni <soniravi829@gmail.com>
|
@Infi-Knight it looks like you have a bunch of conflicts on your branch now. You might want to close this PR and re-open another that's based on the tip of master. |
Fixes #1243
Signed-off-by: Ravi Soni soniravi829@gmail.com