topdown: Fix virtual cache to allow composite key terms #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the virtual cache was implemented using a map[ast.Value]... which works for scalar key terms but not composites (because they're not comparable.) This change updates the virtual cache to use a util.HashMap that supports all term kinds. This prevents the virtual cache lookup/insert from panicing when a key like data.x.y[[1]] is received. In addition to fixing the virtual cache, this change updates the Term.Equal() function to include an early-exit for types that do not allocate in their Equal() functions. The early-exit was added because swapping out the map[ast.Value]... for util.HashMap introduced allocations into the virtual cache lookup/insert operations which doubled the benchmark latency. See below for benchmark results before/after this commit. ``` BEFORE ====== goos: linux goarch: amd64 pkg: github.com/open-policy-agent/opa/topdown BenchmarkVirtualCache-8 5000000 284 ns/op 0 B/op 0 allocs/op PASS ok github.com/open-policy-agent/opa/topdown 1.731s Success: Benchmarks passed. AFTER ===== goos: linux goarch: amd64 pkg: github.com/open-policy-agent/opa/topdown BenchmarkVirtualCache-8 5000000 322 ns/op 0 B/op 0 allocs/op PASS ok github.com/open-policy-agent/opa/topdown 1.969s Success: Benchmarks passed. ``` This change will also let us memoize virtual sets using the same cache (see open-policy-agent#822). Fixes open-policy-agent#1197 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
ashutosh-narkar
approved these changes
Jun 24, 2019
patrick-east
approved these changes
Jun 24, 2019
tsandall
pushed a commit
to tsandall/opa
that referenced
this pull request
Jun 23, 2021
Turns out the groundwork had already been done in open-policy-agent#1520. This changes wires the existing cache into the eval steps of partial sets. Fixes open-policy-agent#822. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the virtual cache was implemented using a
map[ast.Value]... which works for scalar key terms but not composites
(because they're not comparable.) This change updates the virtual
cache to use a util.HashMap that supports all term kinds. This
prevents the virtual cache lookup/insert from panicing when a key like
data.x.y[[1]] is received.
In addition to fixing the virtual cache, this change updates the
Term.Equal() function to include an early-exit for types that do not
allocate in their Equal() functions.
The early-exit was added because swapping out the map[ast.Value]...
for util.HashMap introduced allocations into the virtual cache
lookup/insert operations which doubled the benchmark latency. See
below for benchmark results before/after this commit.
This change will also let us memoize virtual sets using the same cache
(see #822).
Fixes #1197