server: Fix panic in /health?bundle=true #1704
Conversation
The issue was that with bundles loaded from the file system we would not initialize the mutex used for checking bundle status. This fixes the initialization and prevents the error. Health status works as expected now. Fixes: open-policy-agent#1703 Signed-off-by: Patrick East <east.patrick@gmail.com>
|
|
||
| ctx := context.Background() | ||
|
|
||
| err := storage.Txn(ctx, f.server.store, storage.WriteParams, func(txn storage.Transaction) error { |
There was a problem hiding this comment.
What does the health check report before this transaction? Do we have a test that covers that? I'd expect it to be unhealthy if ?bundle is defined.
There was a problem hiding this comment.
In this case it actually returns healthy because there is no known bundle. This test is somewhat synthetic to trigger the panic as it starts the server up without a bundle then fakes adding ones manifest in the store.
Bundles loaded via the data paths are processed when the runtime starts up and before the server ever starts serving so it isn't possible to call the health check. In practice the end result is that calls to the health check fail because the server isn't running yet, and opa would exit with an error initializing the runtime.
The issue was that with bundles loaded from the file system we would
not initialize the mutex used for checking bundle status.
This fixes the initialization and prevents the error. Health status
works as expected now.
Fixes: #1703
Signed-off-by: Patrick East east.patrick@gmail.com