Updates to how query arguments are handled #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes replace the Globals map with a single Request value that contains all of the supplied query arguments. This way it's still possible for the caller to provide a single, non-object value as the request input. Because request has the same semantics as data now, users will no longer receive a special error if the request is missing a required key. This behaviour was somewhat broken anyway as missing embedded keys would not trigger the error. This seems better left to schema checking at the API layer.
timothyhinrichs
approved these changes
Dec 19, 2016
tsandall
added a commit
to tsandall/opa
that referenced
this pull request
Jan 24, 2017
These changes update OPA to analyze queries to determine if an input document is required. In the future, more sophisticated checks could be performed (e.g., JSON schema validation). If an input document is required but not provided, OPA will return HTTP 400 (per the documentation). This was broken in open-policy-agent#197. Fixes open-policy-agent#227
tsandall
added a commit
that referenced
this pull request
Jan 25, 2017
These changes update OPA to analyze queries to determine if an input document is required. In the future, more sophisticated checks could be performed (e.g., JSON schema validation). If an input document is required but not provided, OPA will return HTTP 400 (per the documentation). This was broken in #197. Fixes #227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how query arguments are handled.
Conceptually, all query arguments are now nested inside a built-in root document named "request". This way we can say, somewhat more clearly than before, that policies are expressed against (1) state of the world stored in OPA (nested under data) and (2) the state of the world supplied with the query (nested under request).
The API changes are not backwards compatible: callers need to be updated to supply a "request" parameter instead of a "global" parameter now. The existing integrations are locked to stable versions and will be updated once the next release is published.
/cc @mikol