rego: Fix panic when partial evaluating w/ tracers #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo from a while back that caused problems with this. It would only occur in cases where the Rego object was created without tracers, prepared, and then partially evaluated with tracers supplied as part of the evaluation context. Any of the other code paths would actually work as the original Rego object would still have them and the (wrong) reference wouldn't cause a panic. At some point more recently we changed `opa eval` to split up its options for the Rego object and evaluation. Doing this caused the problem to surface when doing anything with `opa eval -p --explain ..` Fixes: open-policy-agent#2007 Signed-off-by: Patrick East <east.patrick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo from a while back that caused problems with this. It
would only occur in cases where the Rego object was created without
tracers, prepared, and then partially evaluated with tracers supplied
as part of the evaluation context. Any of the other code paths would
actually work as the original Rego object would still have them and
the (wrong) reference wouldn't cause a panic.
At some point more recently we changed
opa evalto split up itsoptions for the Rego object and evaluation. Doing this caused the
problem to surface when doing anything with
opa eval -p --explain ..Fixes: #2007
Signed-off-by: Patrick East east.patrick@gmail.com