topdown: Make http.send() caching use full request #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsandall
reviewed
Feb 17, 2020
patrick-east
force-pushed
the
issue/1980
branch
from
d3bdaa7 to
c7c1cd5
Compare
Previously it just used a string key with the method and url. This causes problems if headers or body contents affect the response, and users were seeing cached responses returned for different requests. The new version takes into account the entire parameters object that is provided to the builtin function. Fixes: open-policy-agent#1980 Signed-off-by: Patrick East <east.patrick@gmail.com>
patrick-east
force-pushed
the
issue/1980
branch
from
c7c1cd5 to
c6a587f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it just used a string key with the method and url. This
causes problems if headers or body contents affect the response, and
users were seeing cached responses returned for different requests.
The new version takes into account the entire parameters object that
is provided to the builtin function.
Fixes: #1980