Improve opa test --verbose and --explain flag usage #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring both `--explain` and `--verbose`/`-v` a user just needs to pass in `--explain` and verbose output will be enabled. Fixes: open-policy-agent#2069 Signed-off-by: Patrick East <east.patrick@gmail.com>
The default value for `--explain` was used when `--verbose`/`-v` was specified. Now if only a verbose flag is specified we will show both "fails" and "notes", which is most likely what someone would want when troubleshooting some test failure. Fixes: open-policy-agent#2068 Signed-off-by: Patrick East <east.patrick@gmail.com>
patrick-east
changed the title
tsandall
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding support for two features (related enough to group together in a single PR).
First up is making the
opa test--explainflag automatically turn on verbose output. This should help for anyone who is trying to see a trace (by providing the flag) and then being surprised when no trace output is shown.The second one is to make it so that the default trace output shown when only specifying
-v/--verboseincludes both "fail" and "note" events. This should help users more easily troubleshoot why tests failed without having to use--explain fulland sifting through all of the output.Closes: #2068
Closes: #2069