Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/website: Fix mobile docs nav menu #2288

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

patrick-east
Copy link
Contributor

We had changed the name of the docs section at some point and missed
updating one spot for the mobile site. This corrects the issue.

Fixes: #2074
Signed-off-by: Patrick East east.patrick@gmail.com

We had changed the name of the docs section at some point and missed
updating one spot for the mobile site. This corrects the issue.

Fixes: open-policy-agent#2074
Signed-off-by: Patrick East <east.patrick@gmail.com>
Copy link
Member

@tsandall tsandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like only the top-level of the ToC is displayed but this is still better than what we had before. LGTM.

@patrick-east
Copy link
Contributor Author

It looks like only the top-level of the ToC is displayed but this is still better than what we had before. LGTM.

Yea :( I came to the same conclusion, at least now all the pages are linked to, someone will just have to scroll around on them or use the search.

We'll probably need to rethink how that gets implemented. The javascript/dynamic ToC we use for the desktop site wont really work well for the mobile like drop down menu bar thing.

@patrick-east patrick-east merged commit aa9f5d7 into open-policy-agent:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile docs website menu is missing a bunch of sections
2 participants