Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.20.5 release #2448

Merged

Conversation

patrick-east
Copy link
Contributor

Including a handful of fixes for:

To unblock some cases of the opa build command and WASM users.

tsandall and others added 4 commits June 1, 2020 10:25
As part of this change, also update the format package to unmangle the
variables slightly differently--just remove the wildcard prefix
instead of translating the variable names. This makes it easier to
tell where the variables came from in the first place and is a bit
less complicated.

Fixes open-policy-agent#2439

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
(cherry picked from commit fe18f11)
The current Wasm import table was missing one required function,
`opa_println`. This just adds it to the list with a quick description.

Signed-off-by: Patrick East <east.patrick@gmail.com>
(cherry picked from commit 3eea0e8)
Previously it was being bound to `$result` but this was then stripped
out of the resultset by the planner. To avoid this issue we need the
variable to not be seen as a wildcard or generated var. The new one
is just `result`.

The documentation is also now updated to show this behavior. The
various client SDK's can strip it out as needed.

The idea is that this is going to just be a part of the built WASM
binary format. Anyone building with the lower level API's using
ad-hoc queries will not need to worry about anything changing.

Fixes: open-policy-agent#2441
Signed-off-by: Patrick East <east.patrick@gmail.com>
(cherry picked from commit 729a853)
Signed-off-by: Patrick East <east.patrick@gmail.com>
Copy link
Member

@tsandall tsandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-east patrick-east merged commit 64dd76e into open-policy-agent:release-0.20 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants