Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IMDSv2 for AWS metadata service #2489

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Implement IMDSv2 for AWS metadata service #2489

merged 1 commit into from
Jun 26, 2020

Conversation

nhw76
Copy link
Contributor

@nhw76 nhw76 commented Jun 24, 2020

Fixes: #2482
Signed-off-by: Nick Williams nhw@me.com

Copy link
Member

@tsandall tsandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhw76 thanks for the quick turnaround! @patrick-east PTAL.

Copy link
Contributor

@patrick-east patrick-east left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good, just a couple questions and comments, nothin major.

plugins/rest/aws.go Show resolved Hide resolved
plugins/rest/aws.go Show resolved Hide resolved
plugins/rest/aws.go Show resolved Hide resolved
patrick-east
patrick-east previously approved these changes Jun 26, 2020
@patrick-east
Copy link
Contributor

Go ahead and squash the PR commits together and we can get this merged in

@nhw76
Copy link
Contributor Author

nhw76 commented Jun 26, 2020

OK I fat-fingered something in the squash commit; let me fix that up.

Fixes: #2482
Signed-off-by: Nick Williams <nhw@me.com>
@nhw76
Copy link
Contributor Author

nhw76 commented Jun 26, 2020

OK squashed.

@patrick-east patrick-east merged commit d60c9fe into open-policy-agent:master Jun 26, 2020
@nhw76 nhw76 deleted the imdsv2 branch June 26, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IMDSv2 for AWS authentication
3 participants