ast: Disqualify indexing if candidate found in nested comprehension #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaspervdj-luminal PTAL. |
|
We should probably backport this onto v0.20 and v0.21 as bugfix releases. |
jaspervdj-luminal
previously approved these changes
Jul 8, 2020
In v0.20. we added support for indexing and caching of comprehensions in certain cases. There was a bug in the index construction that allowed for comprehensions to be indexed and cached incorrectly. Specifically, if any of the candidate keys appear in nested comprehensions, indexing should not be performed because the evaluator does not close over variable bindings from the outer scope when evaluating the comprehension (because this would require cache invalidation if there were multiple assignments to the variables in the outer scope). This fix updates the compiler to check if the candidates appear inside of any nested comprehensions. If a match is found, no indexing is performed. Fixes open-policy-agent#2497 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.20. we added support for indexing and caching of comprehensions
in certain cases. There was a bug in the index construction that
allowed for comprehensions to be indexed and cached
incorrectly. Specifically, if any of the candidate keys appear in
nested comprehensions, indexing should not be performed because the
evaluator does not close over variable bindings from the outer scope
when evaluating the comprehension (because this would require cache
invalidation if there were multiple assignments to the variables in
the outer scope).
This fix updates the compiler to check if the candidates appear inside
of any nested comprehensions. If a match is found, no indexing is
performed.
Fixes #2497
Signed-off-by: Torin Sandall torinsandall@gmail.com