planner: Correct crash in virtual doc iteration #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-east
commented
Aug 19, 2020
patrick-east
force-pushed
the
issue/2601
branch
from
c97c065 to
78e5085
Compare
tsandall
reviewed
Aug 20, 2020
There was an issue with iterating over virtual docs when planning an expression that had `with` keywords. The iterator would potentially be called multiple times, so the "with" values needed to be pushed and popped accordingly. This essentially copies the pattern used in the topdown eval flow. Fixes: open-policy-agent#2601 Signed-off-by: Patrick East <east.patrick@gmail.com>
The assert helper was enforcing the order of a resultset, but the order is non-deterministic. What we really care about it that all expected results are contained in the set (well.. array). Signed-off-by: Patrick East <east.patrick@gmail.com>
patrick-east
force-pushed
the
issue/2601
branch
from
78e5085 to
78d70f7
Compare
tsandall
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with iterating over virtual docs when planning
an expression that had
withkeywords. The iterator would potentiallybe called multiple times, so the "with" values needed to be pushed
and popped accordingly. This essentially copies the pattern used in
the topdown eval flow.
Fixes: #2601
Signed-off-by: Patrick East east.patrick@gmail.com