wasm: fix some bugs wrt. comparisons, ordering #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since anything can happen, we now list the possibilities (3! = 6), and check that any of them was the result. Fixes open-policy-agent#2924. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Same as in topdown, we should have this be true in wasm:
round(1.5) == 2
round(2.5) == 3
The default rounding mode for libmpdec's maxcontext was MPD_ROUND_HALF_EVEN,
would would round 2.5 to 2.
See https://www.bytereef.org/mpdecimal/doc/libmpdec/context.html#rounding
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
I'm not exactly sure why we had been rounding here before. Topdown truncates
when formatting a decimal number as int:
format_int(15.9, 16) == "f"
format_int(-15.9, 16) == "-f"
Fixes open-policy-agent#2923.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/cases: disregard ordering in "strings/concat: set" test
Since anything can happen, we now list the possibilities (3! = 6), and check that any of them was the result.
Fixes wasm: String concat set ordering #2924.
wasm: fix rounding mode
Same as in topdown, we should have this be true in wasm:
The default rounding mode for libmpdec's maxcontext was MPD_ROUND_HALF_EVEN, would would round 2.5 to 2.
See https://www.bytereef.org/mpdecimal/doc/libmpdec/context.html#rounding
wasm: fix number truncation format_int
I'm not exactly sure why we had been rounding here before. Topdown truncates when formatting a decimal number as int:
Fixes wasm: format_int "strings: invalid rounding: internal error" #2923.