topdown: Fixing nanos int overflow issue for time.* built-in functions #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go Time.UnixNano() function result is undefined for dates that cannot fit into an int64 when converted to Unix time in nanoseconds. Updating built-in functions to return error if date is too low/high. Fixes: open-policy-agent#4098 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
johanfylling
commented
Dec 9, 2021
Adjusting min allowed time to be '1677-09-21 00:12:43.145224192'. Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Making nanosecond overflow error message more concise. Updating relevant time.* built-ins to be registered with RegisterBuiltinFunc(). Signed-off-by: Johan Fylling <johan.dev@fylling.se>
srenatus
previously approved these changes
Dec 10, 2021
Updating docs for built-in functions. Signed-off-by: Johan Fylling <johan.dev@fylling.se>
johanfylling
deleted the
fix/4098/builtin-parse_rfc3339_ns_int_overflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go Time.UnixNano() function result is undefined for dates that
cannot fit into an int64 when converted to Unix time in nanoseconds.
Updating built-in functions to return error if date is too low/high.
Fixes: #4098
Signed-off-by: Johan Fylling johan.dev@fylling.se