sdk: allow use of StrictBuiltinErrors #5438
Conversation
charlieegan3
changed the title
There was a problem hiding this comment.
Perhaps @philipaconrad or @srenatus could weigh in as well on the approach, but LGTM!
There was a problem hiding this comment.
@charlieegan3 Overall, this looks great so far! 😄
One small concern I spotted that's tripped me up before: We probably want the ability to have strict errors during partial evaluation too.
It looks like opa_test.go has some partial eval examples you can pull from for tests, and the plumbing should be relatively straightforward. If you want to tackle partial eval in a followup PR, feel free to merge this one now. If you choose to extend this PR, just ping me when you're ready for review again. 👍
There was a problem hiding this comment.
LGTM. I'm with @philipaconrad wrt partial eval, adding stuff here or having a follow-up PR is all the same to me. 😃
|
Thanks all, I think it makes sense to do it in this PR. I'm working on this now 🙂 |
charlieegan3
dismissed stale reviews from srenatus, philipaconrad, and anderseknert
via
a8212e6
This allows the struct builtin errors functionality to be used in the SDK by passing the value in DecisionOptions. Related to #5176 Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Feedback from PR review Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The unknown values are not needed for the test to function so they have been removed. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
charlieegan3
changed the title
This allows the struct builtin errors functionality to be used in the SDK by passing the value in DecisionOptions & PartialOptions.
Related to #5176