runtime: Fix opentelemetry gracefull shutdown #6664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running OPA with the distributed tracing option enabled, the OpenTelemetry trace exporter is not gracefully shut down when the server is stopped. This PR fixes that issues by moving the trace exporter shutdown in the gracefulShutdonw function. Fixes: open-policy-agent#6651 Signed-off-by: Nicolas Chotard <nicolas.chotard@backmarket.com>
There was a problem hiding this comment.
Thanks for the fix @nicolaschotard . It would be great if we can add a test case to verify the behavior.
|
@nicolaschotard can you please add a test case for this when you get a chance and we can get this in. Thanks. |
|
Closing this for now. @nicolaschotard this would be a good one to get in so feel free to re-open when you have a chance to write a test case. Thanks! |
|
Sorry @ashutosh-narkar I've put that aside for too long. But the good news is that it has been taken over 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6651
Why the changes in this PR are needed?
When running OPA with the distributed tracing option enabled, the OpenTelemetry trace exporter is not gracefully shut down when the server is stopped.
What are the changes in this PR?
This PR fixes that issues by moving the trace exporter shutdown in the gracefulShutdonw function.
Extra info
This bug has been introduced by a change in this commit