Allow unregistration of discovery listener #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjungsbluth
force-pushed
the
discovery_unregister_listener
branch
from
a85f695 to
d511518
Compare
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
mjungsbluth
force-pushed
the
discovery_unregister_listener
branch
from
d511518 to
8157756
Compare
srenatus
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM. leaving it up to @johanfylling and @ash-styra to merge 🎈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
The discovery plugin allows to register a bundle download status listener but does not offer a method to unregister a listener
What are the changes in this PR?