-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update envoy-tutorial-istio.md #6896
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Pindar. Have you verified if the tutorial works as expected with this change? If yes, can also please update https://github.com/open-policy-agent/opa-envoy-plugin/blob/main/examples/istio/quick_start.yaml#L9.
@Pindar please let us know once you've verified that the tutorial works as expected with your changes and we can get this in. Thanks. |
Hi @ashutosh-narkar - I can say with certainty that this works with AKS. I was testing a specific scenario: Azure/AKS#3792 (comment) I now added another passage, because it took me hours to find out that the service cannot be found without a namespace in certain cases. A note in the tutorial will hopefully help others. |
@Pindar can you please squash and sign-off your commit and we can get this in. Thanks! |
a3473c9
to
7c2fd06
Compare
@ashutosh-narkar done. |
Correct typ of port in the MeshConfig for extensionProviders and add section about Meshconfig's service value Signed-off-by: Pindar <131621+Pindar@users.noreply.github.com>
7c2fd06
to
17b6cc9
Compare
Correct typ of port in the MeshConfig for extensionProviders
Why the changes in this PR are needed?
The current state doesn’t work. The change reflects the Typ specified by the documentation:
https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#MeshConfig-ExtensionProvider-EnvoyExternalAuthorizationGrpcProvider
What are the changes in this PR?
Change Typ string to int
Notes to assist PR review:
Further comments: