Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/exec: remove "pretty" format #6923

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

srenatus
Copy link
Contributor

This was never supported, and the flag is thus confusing. Since the only supported format is "json" (the default), the flag is redundant now. However, I've kept it so if someone uses opa exec --format=json somewhere, their calls won't become invalid.

If someone had been using opa exec --format=pretty, they will now see an error, but I think that's less confusing: pretty formatting is just not supported for 'opa exec'.

This was never supported, and the flag is thus confusing. Since the
only supported format is "json" (the default), the flag is redundant
now. However, I've kept it so if someone uses `opa exec --format=json`
somewhere, their calls won't become invalid.

If someone had been using `opa exec --format=pretty`, they will now
see an error, but I think that's less confusing: pretty formatting
is just not supported for 'opa exec'.

Signed-off-by: Stephan Renatus <stephan@styra.com>
@anderseknert anderseknert merged commit ed14340 into open-policy-agent:main Aug 13, 2024
28 checks passed
@srenatus srenatus deleted the sr/remove-exec-fmt branch August 13, 2024 12:52
@ashutosh-narkar
Copy link
Member

A change log entry would be helpful to make sure we point this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants