builtins: Marshal JWT encode sign inputs as JSON #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
marshal-jwt-inputs
branch
3 times, most recently
from
5a24c65
to
52db6ed
Compare
johanfylling
approved these changes
Aug 15, 2024
Fixes open-policy-agent#6925 This change modifies the `io.jwt.encode_sign` built-in to marshal the parameters as JSON before signing the JWT. The previous implementation was using String(), which was a sort of pseudo-JSON that was almost correct but used the wrong JSON syntax for the set type. I have chosen to marshal the headers in the same way as the payload as the 'crit' header can also be an array type. I marshal the signature the same way for consistency with the other two. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
marshal-jwt-inputs
branch
from
52db6ed
to
f6b490c
Compare
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6925
This change modifies the
io.jwt.encode_signbuilt-in to marshal the parameters as JSON before signing the JWT. The previous implementation was using String(), which was a sort of pseudo-JSON that was almost correct but used the wrong JSON syntax for the set type.I have chosen to marshal the headers in the same way as the payload as the 'crit' header can also be an array type. I marshal the signature the same way for consistency with the other two.
The tokens have changed in the assertions for whitespace adjustments. Before the 'JSON' looked like this
{"foo": "bar", "bar": "foo"}and now it looks like this{"foo":"bar","bar":"foo"}. This is a shame, but seemed acceptable.