Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos and clarification on signing commits #6940

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

msorens
Copy link
Contributor

@msorens msorens commented Aug 17, 2024

Why the changes in this PR are needed?

  1. Been awhile since I did a PR on this repo so did not remember how the commits needed to be signed. The PR template was not clear how to get to the needed details, so adding them here.
  2. Found assorted typos.

What are the changes in this PR?

As above.

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 8e0a840
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/66c0d3ed54ece00008e20fc7
😎 Deploy Preview https://deploy-preview-6940--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Michael Sorens <msorens@styra.com>
Been awhile since I did a PR on this repo
so did not remember how the commits needed to be signed. The PR template was not clear how to get to the needed details, so adding them here.

Signed-off-by: Michael Sorens <msorens@styra.com>
Copy link
Contributor

@johanfylling johanfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks! 🙂

@johanfylling johanfylling merged commit 07c7bb8 into open-policy-agent:main Aug 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants