build: bump go used for build to 1.23.1 #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/bump-go/1.23.1
branch
2 times, most recently
from
2a3af0a
to
160b17a
Compare
Signed-off-by: Stephan Renatus <stephan@styra.com>
srenatus
force-pushed
the
sr/bump-go/1.23.1
branch
from
160b17a
to
582ad2b
Compare
johanfylling
approved these changes
Sep 9, 2024
| @@ -124,7 +124,7 @@ func TestJSONSerialization(t *testing.T) { | |||
| "go_godebug_non_default_behavior_http2client_events_total", | |||
| "go_godebug_non_default_behavior_http2server_events_total", | |||
| "go_godebug_non_default_behavior_installgoroot_events_total", | |||
| "go_godebug_non_default_behavior_jstmpllitinterp_events_total", | |||
| // "go_godebug_non_default_behavior_jstmpllitinterp_events_total", // this one was removed in 1.23 | |||
There was a problem hiding this comment.
It's a bit annoying how often these change with new go versions 😅.
There was a problem hiding this comment.
Yeah I guess we could also remove the test... but at least it tells us what's there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.