Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.69.0 release #7076

Merged

Conversation

ashutosh-narkar
Copy link
Member

No description provided.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 5b9a116
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/66f71e8a06a04e000889d9c8
😎 Deploy Preview https://deploy-preview-7076--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CHANGELOG.md Outdated
### Topdown and Rego

- Future-proofing tests in the `ast`, `topdown`, `rego` etc. packages to be `1.0` compatible (authored by @johanfylling)
- Add a new inter-query value cache to cache data across queries ([#6908](https://github.com/open-policy-agent/opa/issues/6908)) authored by @ashutosh-narkar reported by @amirsalarsafaei
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make this stand out a bit more: it's got user-facing new config values, for example; and the bullet point doesn't really tell you it's got something to do with glob.match and regex.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the new cache also changes the default cache limit from 100 to infinite for regex and glob matches. It won't affect most users, but we should probably advertise that as it'll affect edge cases.

Copy link
Contributor

@johanfylling johanfylling Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a new section for this, e.g.

### New inter-query Value Cache ([#6908](https://github.com/open-policy-agent/opa/issues/6908))

A new inter-query cache has been added to the SDK. It is intended to be used for values that are expensive to compute and can be reused across multiple queries.
The cache can be leveraged by built-in functions to store values that otherwise aren't appropriate for the existing inter-query cache; for instance when the entry size isn't an appropriate or primary limiting factor for cache eviction.

The default size of he inter-query value cache is unbounded, but can be configured via the `caching.inter_query_builtin_value_cache.max_size` configuration field.

The cache is used by the `regex` and `glob` built-in functions, which previously had individual, non-configurable caches with a max entry size of `100` each.

Authored by @ashutosh-narkar, reported by @amirsalarsafaei

Maybe a bit wordy 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more words, but many settings still use the 100-element cache, I think: opa eval, opa test don't use the server config, and I believe they end up with the old code path. @ashutosh-narkar would know for sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opa eval is just the one query, though. But I suppose even a single one can do a boatload of regex matches 😄, so that is probably good to sort out in the description 👍.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the new cache isn't available for Wasm. Lots more nuance here than a first glance guess ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I've updated the text.

johanfylling
johanfylling previously approved these changes Sep 27, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@johanfylling johanfylling merged commit 4a3fd1a into open-policy-agent:main Sep 30, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants