Allow passing multiple addresses to the server #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the --addr CLI parameter to be a slice and refactors the code to allow several addresses to be passed. Hence we can listen on as many HTTP and UNIX sockets as we want. Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
|
LGTM! |
tsandall
added a commit
to tsandall/opa
that referenced
this pull request
May 30, 2018
With the open-policy-agent#762 and open-policy-agent#764 there is no need to keep the logic for creating the HTTP and HTTPS listeners inside the function. These changes just split listener creation into separate functions for clarity. Also, update runtime to use logrus for reporting initialization errors instead of println for consistency. Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall
added a commit
that referenced
this pull request
May 30, 2018
With the #762 and #764 there is no need to keep the logic for creating the HTTP and HTTPS listeners inside the function. These changes just split listener creation into separate functions for clarity. Also, update runtime to use logrus for reporting initialization errors instead of println for consistency. Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the --addr CLI parameter to be a slice and refactors the code
to allow several addresses to be passed. Hence we can listen on as many
HTTP and UNIX sockets as we want.
Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com