Patch helps to overcome login issue. #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraveenPenguin
approved these changes
Jan 23, 2024
|
I have added the PR to test with CI jobs, we will merge only if everthing goes fine |
|
@abdhaleegit @TasmiyaNalatwad any update on CI run result? |
|
@PraveenPenguin @abdhaleegit , This needs more enhancement. I see the function call self.cv_SYSTEM.console.get_console() is not coming out of this function and remaining there forever time as trying to login with credentials. I am trying to give a timeout to this function call and then try logging in for few times like 5 times in a loop. |
Sometimes the console via ssh is not connected and Login attempt fails, This could be due to network issue. Attempting to login for 5 times if the connection is not established in one go. Signed-off-by: Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>
TasmiyaNalatwad
force-pushed
the
login_fix
branch
from
1b71940 to
daf75b8
Compare
TasmiyaNalatwad
commented
Jan 31, 2024
TasmiyaNalatwad
commented
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the console via ssh is not connected and Login attempt fails, This could be due to network issue. Attempting to login for 5 times if the connection is not established in one go.