Git Bisection Automated for build of a kernel #810

Tejas3772 · 2024-03-12T14:37:04Z

Description

This Pull Request includes a Test_build.py that builds the kernel while checking for build failure, if a build failure is found it directly calls Build_bisector.py that runs the bisection for build using the make.sh file from the test_binaries and finally if the bisection occurred, it returns an output.json file containing the first bad_commit, the email of the Author associated with the commit, failure directory and exit code.

test_binaries/make.sh

testcases/Build_bisector.py

testcases/Test_build.py

OpTestConfiguration.py

test_binaries/make.sh

testcases/Build_bisector.py

sacsant · 2024-03-18T06:50:15Z

testcases/Build_bisector.py

+    Test case for bisecting the Linux kernel using Git Bisect.
+    This test downloads the Linux kernel from a specified repository,
+    configures and compiles it, and then uses Git Bisect to find the
+    commit that introduced a specific issue.


s/specific issue/build failure/ will be apt

testcases/Build_bisector.py

testcases/Test_build.py

testcases/Build_bisector.py

OpTestConfiguration.py

test_binaries/make.sh

OpTestConfiguration.py

sacsant · 2024-04-17T10:55:33Z

test_binaries/make.sh

@@ -0,0 +1,23 @@
+#!/usr/bin/env python3


since this is a shell script, this python related line is not required. Remove it.

@Tejas3772 this is not yet done

sacsant · 2024-04-17T10:55:49Z

test_binaries/make.sh

+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#!/bin/bash


Move this to the top of file.

Tejas3772 · 2024-05-27T07:01:47Z

several changes made and linux-next functionalities added

abdhaleegit

Look at the review comments once again.. I do not see it in the latest code

OpTestConfiguration.py

abdhaleegit · 2024-05-28T09:09:30Z

test_binaries/make.sh

@@ -0,0 +1,23 @@
+#!/usr/bin/env python3


@Tejas3772 this is not yet done

test_binaries/make.sh

testcases/Build_bisector.py

Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

…r multiple uses Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

…or if build faiils Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

OpTestConfiguration.py

abdhaleegit · 2024-05-29T05:57:51Z

testcases/Build_bisector.py

+from common.OpTestSOL import OpSOLMonitorThread
+from common.OpTestInstallUtil import InstallUtil
+from common.Exceptions import CommandFailed
+import test_binaries


move import to above and arrange all imports in alphabaticle order

and add one empty line below

abdhaleegit · 2024-05-29T06:01:03Z

testcases/Build_bisector.py

+        self.console_thread = OpSOLMonitorThread(1, "console")
+        self.host_cmd_timeout = self.conf.args.host_cmd_timeout
+        self.repo = self.conf.args.git_repo
+        self.repo_reference = self.conf.args.git_repo_reference


why 2 params for repo ?

abdhaleegit · 2024-05-29T06:01:34Z

testcases/Build_bisector.py

+        self.branch = self.conf.args.git_branch
+        self.home = self.conf.args.git_home
+        self.config_path = self.conf.args.git_repoconfigpath
+        self.config = self.conf.args.git_repoconfig


it can be single config parameter that can take both path or http link

abdhaleegit · 2024-05-29T06:02:10Z

testcases/Build_bisector.py

+        self.config = self.conf.args.git_repoconfig
+        self.good_commit = self.conf.args.good_commit
+        self.bad_commit = self.conf.args.bad_commit
+        self.bisect_script = self.conf.args.bisect_script


why we need script parameter ?

abdhaleegit · 2024-05-29T06:31:22Z

testcases/Email_git.py

+        PPC KBOT
+        """.format(gcc_version, machine_type, error_message,kernel_version, machine_type, gcc_version, commit,commit, commit, fix_description)
+        print(subject)
+        print(body)


is print require or for debug only .. you decide to keep or remove

abdhaleegit · 2024-05-29T06:31:42Z

testcases/Email_git.py

+
+        with open("email.json","w") as email:
+             json.dump({"subject":subject,"body":body},email)
+        # return subject, body


you should uncomment ? or remove

abdhaleegit · 2024-05-29T06:32:16Z

testcases/Test_build.py

+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# permissions and limitations under the License.


add empty line below and Author name and mail id

abdhaleegit · 2024-05-29T06:32:53Z

testcases/Test_build.py

+from testcases import Email_git
+from common.OpTestSystem import OpSystemState
+from common.OpTestSOL import OpSOLMonitorThread
+from common.Exceptions import CommandFailed


add empty line beflore and 2 empty lines after log line

abdhaleegit · 2024-05-29T07:10:00Z

testcases/Test_build.py

+        """
+        Build and install the Linux kernel.
+        """
+        self.connection.run_command("wget http://ltc-jenkins.aus.stglabs.ibm.com:81/abdul/ioci/kernel_config -o linux/.config")


remove the config link

abdhaleegit · 2024-06-07T06:53:39Z

A new PR is created #849 Which inlcudes all the review comments implemented discussed above and more integrated code

some of the recent review comments

All bisection boot and build libraries should go to common/OpTestUtils.py [DONE]
Move Email.py code into OpTestUtils.py [DONE]
All build and boot linux/os related common methods will go into common/OpTestUtils.py [DONE]
Do not import a testcase inside a testcase, not a good practice [DONE]
Keep build bisection code and email and bisect_flag as separate commit but single PR [DONE]
relook at the linux-next bisection code and push updated code in same PR [DONE]
Rerun the build bisection once with all above changes [DONE]

Once build PR merge, rebase your code and send boot bisection code with new PR

Tejas3772 · 2024-07-30T09:28:10Z

new pr merged

abdhaleegit self-requested a review March 13, 2024 10:32

PraveenPenguin requested changes Mar 14, 2024

View reviewed changes

sacsant suggested changes Mar 18, 2024

View reviewed changes

sacsant reviewed Mar 18, 2024

View reviewed changes

testcases/Test_build.py Outdated Show resolved Hide resolved

Tejas3772 force-pushed the git_bisect branch from 3553e0e to 550c885 Compare March 19, 2024 05:32

TasmiyaNalatwad suggested changes Mar 19, 2024

View reviewed changes

testcases/Test_build.py Show resolved Hide resolved

testcases/Test_build.py Outdated Show resolved Hide resolved

TasmiyaNalatwad reviewed Mar 19, 2024

View reviewed changes

testcases/Build_bisector.py Outdated Show resolved Hide resolved

Tejas3772 force-pushed the git_bisect branch 2 times, most recently from 4e913ee to b303489 Compare March 25, 2024 09:13

abdhaleegit requested changes Apr 1, 2024

View reviewed changes

OpTestConfiguration.py Outdated Show resolved Hide resolved

test_binaries/make.sh Outdated Show resolved Hide resolved

Tejas3772 force-pushed the git_bisect branch 13 times, most recently from 6605c90 to d575d90 Compare April 4, 2024 06:57

Tejas3772 force-pushed the git_bisect branch 7 times, most recently from 7844a49 to ec27074 Compare April 17, 2024 10:31

sacsant suggested changes Apr 17, 2024

View reviewed changes

Tejas3772 force-pushed the git_bisect branch 2 times, most recently from 0fa3418 to df05273 Compare April 18, 2024 06:56

Tejas3772 closed this May 27, 2024

Tejas3772 reopened this May 28, 2024

Tejas3772 force-pushed the git_bisect branch 2 times, most recently from 5565e32 to e28cc92 Compare May 28, 2024 07:25

abdhaleegit self-requested a review May 28, 2024 09:05

abdhaleegit requested changes May 28, 2024

View reviewed changes

Tejas3772 force-pushed the git_bisect branch 2 times, most recently from b8aefee to 5c0209b Compare May 28, 2024 10:55

Adding the make file to build the kernel in test_binaries

18ed560

Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

Tejas3772 force-pushed the git_bisect branch from 5c0209b to 97ea593 Compare May 28, 2024 11:04

abdhaleegit self-assigned this May 28, 2024

Tejas3772 force-pushed the git_bisect branch from 97ea593 to 69600f7 Compare May 28, 2024 13:07

Adding the build bisector as a class implementation to be accessed fo…

9884f26

…r multiple uses Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

Tejas3772 force-pushed the git_bisect branch 5 times, most recently from 944e722 to 7f71edf Compare May 28, 2024 14:10

Tejas Manhas added 2 commits May 28, 2024 19:52

Added the Test_build.py that builds the kernel and calls Build_bisect…

a465248

…or if build faiils Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

Adding functionalities for linux-next and email

c1f976c

Signed-off-by: Tejas Manhas <Tejas.Manhas@ibm.com>

Tejas3772 force-pushed the git_bisect branch from 7f71edf to c1f976c Compare May 28, 2024 14:23

abdhaleegit self-requested a review May 28, 2024 14:27

abdhaleegit requested changes May 29, 2024

View reviewed changes

Tejas3772 closed this Jul 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Git Bisection Automated for build of a kernel #810

Git Bisection Automated for build of a kernel #810

Tejas3772 commented Mar 12, 2024

sacsant Mar 18, 2024

sacsant Apr 17, 2024

abdhaleegit May 28, 2024

sacsant Apr 17, 2024

Tejas3772 commented May 27, 2024

abdhaleegit left a comment

abdhaleegit May 28, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit May 29, 2024

abdhaleegit commented Jun 7, 2024

Tejas3772 commented Jul 30, 2024

Git Bisection Automated for build of a kernel #810

Git Bisection Automated for build of a kernel #810

Conversation

Tejas3772 commented Mar 12, 2024

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tejas3772 commented May 27, 2024

abdhaleegit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abdhaleegit commented Jun 7, 2024

Tejas3772 commented Jul 30, 2024