Replacing Paramiko with ssh connection to host #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ssh connection to host is used to get directory paths, htxerr files and many other validations. Signed-off-by: Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>
TasmiyaNalatwad
force-pushed
the
paramiko_to_ssh
branch
from
8f496af to
91205e6
Compare
|
@abdhaleegit All the logs i have attached to jira covering all the scenarios. |
TasmiyaNalatwad
commented
Apr 24, 2024
| dev_base = self.execute_remote_command('basename $(realpath {})'.format(dev_path)) | ||
| if device == dev_base: | ||
| return dev_path | ||
| return device |
There was a problem hiding this comment.
@abdhaleegit I am removing these functions as i am directly running commands on host and getting the device paths, Tested this by providing 2 different paths as '/dev/mapper/mpatha' and '/dev/sda' it worked fine in both the cases.
|
@PraveenPenguin Removed paramiko as per your suggestion.. please ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ssh connection to host is used to get directory paths, htxerr files and many other validations.