Allow libpki to verify quantum safe signatures #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
reviewed
Mar 5, 2024
Thank you for pointing this out! I’ve deleted it. This was an old implementation that has been replaced by the change in |
|
@baentsch Do you have any new suggestions? If no, I'll merge this PR and update OQS-Chromium build instructions in oqs-demos. |
baentsch
reviewed
Mar 8, 2024
baentsch
reviewed
Mar 8, 2024
baentsch
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
@baentsch Do you have any new suggestions? If no, I'll merge this PR and update OQS-Chromium build instructions in oqs-demos.
Nope, just questions :) See above. But nothing that couldn't be fixed later on. Updating oqs-chromium instructions would be very welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will create some new templates in oqs_template later